fixed: attempt to write null to registry after clearing ApplicationInput#8
Open
rbares wants to merge 1 commit intoPulse-Eight:masterfrom
Open
fixed: attempt to write null to registry after clearing ApplicationInput#8rbares wants to merge 1 commit intoPulse-Eight:masterfrom
rbares wants to merge 1 commit intoPulse-Eight:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
Previously button mappings (ApplicationInput) were cleared by setting them to null, however when saving configuration this could easily result in an attempt to write null to the registry which would raise an exception. This diff clears ApplicationInput by clearing the inner _input list, enabling CECSettings to correctly write an empty string instead. This is correctly interpreted when read from the registry and avoids the crash.